Re: [PATCH v1] ACPI: bus: Fix typo under sizeof() in acpi_run_osc()

From: Jonathan Cameron

Date: Fri Jan 02 2026 - 06:38:47 EST


On Mon, 29 Dec 2025 14:27:46 +0100
"Rafael J. Wysocki" <rafael@xxxxxxxxxx> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Subject:
>
> The sizeof(32) in acpi_run_osc() should be sizeof(u32), so fix it.
>
> Fixes: e5322888e6bf ("ACPI: bus: Rework the handling of \_SB._OSC platform features")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>

> ---
>
> Commit e5322888e6bf is a linux-next one.
>
> ---
> drivers/acpi/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -294,7 +294,7 @@ acpi_status acpi_run_osc(acpi_handle han
> int ret;
>
> if (!context || !context->cap.pointer ||
> - context->cap.length < 2 * sizeof(32) ||
> + context->cap.length < 2 * sizeof(u32) ||
> guid_parse(context->uuid_str, &guid))
> return AE_BAD_PARAMETER;
>
>
>
>
>