Re: [PATCH 3/4] ASoC: codecs: wsa884x: fix codec initialisation

[Krzysztof Kozlowski]

On 02/01/2026 13:17, Johan Hovold wrote:
>>> 	...
>>>
>>> 	wsa884x_init(wsa884x);
>>>
>>> so if you set hw_init to true then init is never called when status is
>>> changed to ATTACHED.
>>
>> Uh, indeed, so this was supposed to be !wsa884x->hw_init... or indeed
>> your meaning. This also means that this was never passing above if() and
>> the init() was never called.
>>
>> regcache was probably synced via runtime PM, so at least that part worked.
>>
>> Did you test this driver on actual device how it affects the behavior?
> 
> No, I don't have a device that uses this codec anymore.
> 
> If you could give it a spin that would be great. It seems we have been
> depending on reset values or an UNATTACHED => ATTACHED transition so
> far.

I can test it, maybe after the weekend.

Best regards,
Krzysztof