Re: [PATCH 0/3] scripts: generate_rust_analyzer: match rust/Makefile

[Tamir Duberstein]

On Fri, Jan 2, 2026 at 3:05 PM Benno Lossin <lossin@xxxxxxxxxx> wrote:
>
> On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
> > @Benno would you mind having a look at this series?
>
> Oh wow this is an old series! Sorry for missing it.
>
> I'm not maintaining the build system for pin-init, but from my side the
> changes look okay. The commit messages are missing some context though:
> why do we need these dependency edges? etc. If you fix that you can add
>
> Acked-by: Benno Lossin <lossin@xxxxxxxxxx>
>
> Also note that this might be different in the new build system.

Thanks for the review! I think the commits all include answers to
"why": the first two make RA match the actual build and the final one
does the same and also fixes navigation in pin_init_internal; before
this series, go-to-symbol from pin_init_internal to e.g.
proc_macro::TokenStream doesn't work.