Re: [PATCH 1/2] clk: qcom: gcc-kaanapali: Fix double array initializer

[Bjorn Andersson]

On Fri, Jan 02, 2026 at 03:10:10PM -0600, Bjorn Andersson wrote:
> On Wed, Dec 24, 2025 at 12:22:58PM +0100, Krzysztof Kozlowski wrote:
> > [GCC_QMIP_VIDEO_VCODEC_AHB_CLK] element in clk_regmap array is already
> > initialized, as reported by W=1 clang warning:
> > 
> >   gcc-kaanapali.c:3383:36: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> > 
> > Fixes: d1919c375f21 ("clk: qcom: Add support for Global clock controller on Kaanapali")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > 
> > ---
> > 
> > Does anyone even build this code before sending it to upstream?
> 
> It hope the author does...but I of couse sanity check the result through
> an allmodconfig build across a few different architectures before
> pushing.
> 
> But it seems passing '--environment "W=1"' to tuxmake doesn't actually
> enable these warnings :(
> 

Realized that W=1 should be passed as a build target, not through
environment.

Do you have any sensible post-processing tools/steps that you could
share to make the output usable?

Regards,
Bjorn

> Thanks for the report, and the fixes.
> 
> Regards,
> Bjorn
> 
> > ---
> >  drivers/clk/qcom/gcc-kaanapali.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/clk/qcom/gcc-kaanapali.c b/drivers/clk/qcom/gcc-kaanapali.c
> > index 182b152df14c..b9743284927d 100644
> > --- a/drivers/clk/qcom/gcc-kaanapali.c
> > +++ b/drivers/clk/qcom/gcc-kaanapali.c
> > @@ -3380,7 +3380,6 @@ static struct clk_regmap *gcc_kaanapali_clocks[] = {
> >  	[GCC_QMIP_VIDEO_CV_CPU_AHB_CLK] = &gcc_qmip_video_cv_cpu_ahb_clk.clkr,
> >  	[GCC_QMIP_VIDEO_CVP_AHB_CLK] = &gcc_qmip_video_cvp_ahb_clk.clkr,
> >  	[GCC_QMIP_VIDEO_V_CPU_AHB_CLK] = &gcc_qmip_video_v_cpu_ahb_clk.clkr,
> > -	[GCC_QMIP_VIDEO_VCODEC_AHB_CLK] = &gcc_qmip_video_vcodec_ahb_clk.clkr,
> >  };
> >  
> >  static struct gdsc *gcc_kaanapali_gdscs[] = {
> > -- 
> > 2.51.0
> >