Re: [PATCH] arm64: dts: qcom: ipq9574: Enable eMMC variant

[Dmitry Baryshkov]

On Fri, Jan 02, 2026 at 02:09:04PM -0600, Bjorn Andersson wrote:
> On Fri, Jan 02, 2026 at 12:08:03PM +0100, Krzysztof Kozlowski wrote:
> > On 02/01/2026 11:46, Varadarajan Narayanan wrote:
> > > RDP433 can have NAND or eMMC based on a board level rework. Since the
> > > same GPIOS are used for both the interfaces, only one of them can be
> > > used. Add a new DTS file to disable NAND and enable eMMC.
> > > 
> > > Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/qcom/Makefile             |  2 +-
> > >  .../boot/dts/qcom/ipq9574-rdp-common.dtsi     | 32 +++++++++++++++++++
> > >  .../boot/dts/qcom/ipq9574-rdp433-emmc.dts     | 26 +++++++++++++++
> > >  3 files changed, 59 insertions(+), 1 deletion(-)
> > >  create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts
> > > 
> > 
> > > +/*
> > > + * IPQ9574 RDP433 eMMC board variant device tree source
> > > + *
> > > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "ipq9574-rdp433.dts"
> > 
> > I find it discouraged practice. Although if Bjorn is fine with it, you
> > still need proper compatibles.
> > 
> 
> Nah, I don't fancy including .dts files. But I do see that I've let a
> few of those slip by over the years.
> 
> The general approach for these cases has been to rename dts->dtsi and
> create the two dts files.
> 
> I wonder though if this would be better served by an overlay, as it's
> the same board, but with modifications applied?

I think, overlay is a better fit here.

> 
> Regards,
> Bjorn
> 
> > 
> > Best regards,
> > Krzysztof

-- 
With best wishes
Dmitry