Re: [PATCH v5 7/7] leds: Add virtual LED group driver

[Andriy Shevencho]

On Sat, Jan 03, 2026 at 08:22:06AM +0000, Jonathan Brophy wrote:

> >I stopped with this, this patch is half-baked and unreviewable. Please, split
> >it to a few features and add one-by-one, for example:
> 
> >- very basic sypport
> >- feature A
> >- ...
> >- debugfs
> 
> >So I expect 3+ patches out of this one. And try to keep size of a change less
> >than 1000 LoCs.
> 
> Thanks Andy
> 
> You have given me some things to fix and some great advice I'm a very junior dev and
> I know nothing of the led subsystem before this project.

You're welcome!

> I think it may be best to use a function to generate a gamma table I was thinking a
> hard coded table may be a better idea for performance reasons with addressable rgb
> strips that I plan to implement in the future.
> 
> I planned to split the driver into several files is this what you mean?
> it would logically break into  files as part of the driver as follows:
> 
> core.c
> arbitration.c
> phys.c
> vled.c
> debugfs.c
> virtualcolor.h

Fine by me, but I'm not a maintainer nor the authoritative person, you need to
wait for Jacek, and/or Lee, and/or Pavel to express their opinions.

-- 
With Best Regards,
Andy Shevchenko