Re: [PATCH] drivers: pwm: replace `kernel::c_str!` with C-Strings
From: Tamir Duberstein
Date: Sat Jan 03 2026 - 21:31:50 EST
On Mon, Dec 22, 2025 at 7:24 AM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> From: Tamir Duberstein <tamird@xxxxxxxxx>
>
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> ---
> drivers/pwm/pwm_th1520.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
> index e3b7e77356fc..8ae8f852ec02 100644
> --- a/drivers/pwm/pwm_th1520.rs
> +++ b/drivers/pwm/pwm_th1520.rs
> @@ -22,7 +22,6 @@
>
> use core::ops::Deref;
> use kernel::{
> - c_str,
> clk::Clk,
> device::{Bound, Core, Device},
> devres,
> @@ -327,7 +326,7 @@ fn drop(self: Pin<&mut Self>) {
> OF_TABLE,
> MODULE_OF_TABLE,
> <Th1520PwmPlatformDriver as platform::Driver>::IdInfo,
> - [(of::DeviceId::new(c_str!("thead,th1520-pwm")), ())]
> + [(of::DeviceId::new(c"thead,th1520-pwm"), ())]
> );
>
> impl platform::Driver for Th1520PwmPlatformDriver {
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-pwm-c9b9a4701157
>
> Best regards,
> --
> Tamir Duberstein <tamird@xxxxxxxxx>
>
@Uwe could you please have a look?
Cheers.
Tamir