Re: [PATCH] rust: pci: add HeaderType enum and header_type() helper
From: Danilo Krummrich
Date: Sun Jan 04 2026 - 08:40:28 EST
On Sat Jan 3, 2026 at 4:39 PM CET, 하승종 wrote:
> 2026년 1월 4일 (일) AM 12:17, Danilo Krummrich <dakr@xxxxxxxxxx>님이 작성:
>>
>> On Sat Jan 3, 2026 at 3:38 PM CET, SeungJong Ha via B4 Relay wrote:
>> > This is my first patch to the Linux kernel, specifically targeting the
>> > Rust PCI subsystem.
>>
>> Thanks for your contribution!
>>
>> > This patch introduces the HeaderType enum to represent PCI configuration
>> > space header types (Normal and Bridge) and implements the header_type()
>> > method in the Device struct.
>>
>> We usually do not add dead code in the kernel. Do you work on a user for this
>> API?
>
> Hi Danilo, Thanks for your feedback.
>
> Yes, I am currently developing a Rust-based driver for nvme and ixgbe devices,
> which requires identifying the header type to check compatibility on
> initialization.
> I sent this patch first as it provides a foundational API for the PCI
> abstraction.
As Miguel also pointed out in his reply, I'd like to see a patch series with the
driver as an RFC patch.
If it is working, not too far from an "upstreamable" state and the subsystem
maintainers of the driver's target subsystem are indicating willingness to
eventually take the driver, I'm happy to go ahead and merge any dependencies.
- Danilo