Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator

[Ian Rogers]

On Sun, Jan 4, 2026 at 10:54 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2026-01-05 at 01:37 +0800, Kuan-Wei Chiu wrote:
> > +Cc Andrew Morton,
> []
>
> > That said, any Ack/Review or feedback from checkpatch.pl
> > maintainers/reviewers would still be helpful and appreciated.
>
>
> I think most of this is pointless and incorrect besides.
> A patch separator is specifically 3 dashes not a line that
> starts with 3 or more dashes.

Thanks Joe, do you have a reference for this? I was going off-of git's
behavior and I think the commit message covers that this patch is
fixing checkpatch.pl's behavior to match that of git's wrt lines
starting '---'. Or are you saying that git is broken and we should
patch git? In this case it would still be a useful lint test for
checkpatch.pl to warn about the '---' behavior for old versions of git
- at some future date when all gits have the patch then the
checkpatch.pl behavior can switch from '^---' to '^---$' again. In
summary, I think it is still the right thing for this patch to be
carried unless you have other concerns - could you be more specific on
what you mean by "most of this".

Thanks,
Ian

> See the original problem
> https://lore.kernel.org/lkml/20251203214706.112174-7-irogers@xxxxxxxxxx/