Re: [PATCH v4] mm/vmscan: fix demotion targets checks in reclaim/demotion

[Bing Jiao]

On Mon, Jan 05, 2026 at 10:48:09AM +0800, Chen Ridong wrote:
> >  	cs = container_of(css, struct cpuset, css);
> > -	allowed = node_isset(nid, cs->effective_mems);
> > +	nodes_and(*mask, *mask, cs->effective_mems);
>
> Why do we need the and operation? Can't we just copy cs->effective_mems to mask directly?
>
> Per Longman's suggestion, name it cpuset_nodes_allowed and handle the filtering in
> mem_cgroup_node_filter_allowed. Please keep the allowed nodes retrieval logic common.
>
> Best regards,
> Ridong

Thank you for the explanation and suggestions.

Patch v5 has been sent with the corresponding updates.

Best,
Bing