Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment
From: Greg KH
Date: Mon Jan 05 2026 - 01:26:15 EST
On Sun, Jan 04, 2026 at 07:30:22PM +0100, Miguel Ojeda wrote:
> On Sun, Jan 4, 2026 at 3:08 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
> >
> > In general I prefer to only add a Fixes: tag for the commit that introduced the
> > issue.
>
> If their scripts track moves well, then it is great to avoid it, but I
> am not sure how well that works or not or in which cases, i.e. it
> could look like two different commits introduced the issue and thus
> one backport could be missed. Not sure.
>
> > Again, I could also remember this wrongly, but I think I just recently reviewed
> > such a commit from Sasha. :)
>
> Hmm... I also had a few cases where Sasha autoapplied, but in most
> cases, I had to provide custom patches when they didn't apply cleanly,
> even trivial ones.
It all depends, sometimes we can handle file moves easily, sometimes we
can not.
But really, why is a comment typo being needed in stable kernels?
thanks,
greg k-h