[PATCH 13/15] net: ftgmac100: Simplify error handling for ftgmac100_setup_mdio
From: Jacky Chou
Date: Mon Jan 05 2026 - 02:10:49 EST
From: Andrew Lunn <andrew@xxxxxxx>
ftgmac100_setup_mdio() cleans up any resources it gets on error. All
resources obtained by the probe function up until this call point use
devm_ methods. So just return the error code rather than use a goto.
Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
Signed-off-by: Jacky Chou <jacky_chou@xxxxxxxxxxxxxx>
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 23a2212ee3bc..982944ab1ff1 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -2012,7 +2012,7 @@ static int ftgmac100_probe(struct platform_device *pdev)
priv->mac_id == FTGMAC100_AST2500) {
err = ftgmac100_setup_mdio(netdev);
if (err)
- goto err_phy_connect;
+ return err;
}
if (np) {
--
2.34.1