Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds
From: Benno Lossin
Date: Mon Jan 05 2026 - 03:55:35 EST
On Sun Jan 4, 2026 at 2:35 PM CET, Tamir Duberstein wrote:
> On Thu, Dec 11, 2025 at 2:28 PM Gary Guo <gary@xxxxxxxxxx> wrote:
>>
>> From: Benno Lossin <lossin@xxxxxxxxxx>
>>
>> The kernel only had the `proc-macro` library available, whereas the
>> user-space version also used `proc-macro2` and `quote`. Now both are
>> available to the kernel, making it possible to remove the workarounds.
>>
>> Signed-off-by: Benno Lossin <lossin@xxxxxxxxxx>
>> Co-developed-by: Gary Guo <gary@xxxxxxxxxxx>
>> Signed-off-by: Gary Guo <gary@xxxxxxxxxxx>
>
> This adds a dependency edge from pin-init-internal to syn, but syn is
> not actually used in pin-init or pin-init-internal.
>
> There's a comment in rust/pin-init/src/macros.rs that suggests syn
> might be used in the future, but as of this comment this is a dead
> dependency edge.
I have a patchset prepared in [1] and plan to send that this cycle.
[1]: https://github.com/Rust-for-Linux/pin-init/pull/89
Cheers,
Benno