Re: [PATCH] ARM: omap2: Fix reference count leaks in omap_control_init()

From: Andreas Kemnade
Date: Mon Jan 05 2026 - 04:39:44 EST


On Wed, 17 Dec 2025 14:21:22 +0000
Wentao Liang <vulab@xxxxxxxxxxx> wrote:

> The of_get_child_by_name() function increments the reference count
> of child nodes, causing multiple reference leaks in omap_control_init():
>
> 1. scm_conf node never released in normal/error paths
> 2. clocks node leak when checking existence
> 3. Missing scm_conf release before np in error paths
>
> Fix these leaks by adding proper of_node_put() calls and separate error
> handling.
>
> Fixes: e5b635742e98 ("ARM: OMAP2+: control: add syscon support for register accesses")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>

Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>