Re: [PATCH] pci: controller: tegra194: remove dependency on Tegra194 SoC

[Niklas Cassel]

On Mon, Jan 05, 2026 at 01:14:01PM +0100, Niklas Cassel wrote:
> > > > So, I think we could just merge:
> > > > https://lore.kernel.org/linux-pci/20250508051922.4134041-1-vidyas@xxxxxxxxxx/
> > > > 
> > > > (Assuming it still applies.)
> > > 
> > > Yes it does and applying Sagar's patch is fine with me. So it you want to
> > > apply Sagar's patch please add my ...
> > > 
> > 
> > Don't we need:
> > 
> > 	depends on (ARCH_TEGRA && ARM64) || COMPILE_TEST
> 
> This is exactly what I originally suggested to Vidya:
> https://lore.kernel.org/linux-pci/Z6XjWJd9jm0HHNXW@ryzen/
> 
> 
> > 
> > in the above patch?
> 
> The above patch instead has:
> 
> depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)
> 
> I don't know why Vidya did not use my suggestion exactly, but I guess I
> assumed that he had a reason not to use my suggestion exactly.


Looking at drivers/pci/controller/dwc/Kconfig,
there are a lot of:

depends on OF && (ARM64 || COMPILE_TEST)

So I think Vidya simply followed this pattern and instead did:
depends on ARCH_TEGRA && (ARM64 || COMPILE_TEST)


But, since we don't have an explicit "depends on OF"
in these entries, I do think that:

depends on (ARCH_TEGRA && ARM64) || COMPILE_TEST

is slightly more correct. (Since if there was a hard requirement on OF,
it would have been there already).


Kind regards,
Niklas