Re: [PATCH] platform/surface: Replace deprecated strcpy in surface_button_add
From: Thorsten Blum
Date: Mon Jan 05 2026 - 08:43:13 EST
On 5. Jan 2026, at 13:52, Chen, Yu C wrote:
>> - strcpy(name, SURFACE_BUTTON_DEVICE_NAME);
>> + strscpy(acpi_device_name(device), SURFACE_BUTTON_DEVICE_NAME);
>
> Thanks for the fix, a minor question might be why we do not reuse
> name by strscpy(name, SURFACE_BUTTON_DEVICE_NAME) ?
Because 'name' is a 'char *' from which the size of the destination
buffer cannot be inferred by the 2-argument version of strscpy().
Using 'name' would force us to use strscpy() with 3 arguments:
strscpy(name, SURFACE_BUTTON_DEVICE_NAME, MAX_ACPI_DEVICE_NAME_LEN);
Thanks,
Thorsten