Re: [PATCH 2/2] rust: quote: make rust-analyzer treat `core` and `std` as dependencies

From: Miguel Ojeda
Date: Mon Jan 05 2026 - 09:07:48 EST


On Mon, Jan 5, 2026 at 1:12 PM Jesung Yang <y.j3ms.n@xxxxxxxxx> wrote:
>
> IIUC, to remove `std`, we need to patch our vendored `syn` as well to
> not depend on `std`, right? I think it is indeed a desired change.
>
> If you don't mind, I'm happy to patch the vendored `syn` along with
> this series if the team agrees. Alternatively, if you'd prefer to send
> the patch yourself, please let me know.

What are the advantages/disadvantages of doing so? Performance in rust-analyzer?

In general, I would prefer to avoid patching vendored dependencies,
but if there is an advantage, then I think it is fine to have small
changes as long as upstream has merged their PR (i.e. so that we at
least know there is a good chance we will eventually get the same
change when we upgrade the dependency).

Thanks!

Cheers,
Miguel