Re: [PATCH net v2 1/2] net: netdevsim: fix inconsistent carrier state after link/unlink

From: Yohei Kojima

Date: Mon Jan 05 2026 - 10:50:50 EST


On Sun, Jan 04, 2026 at 10:54:22AM -0800, Jakub Kicinski wrote:
> On Wed, 31 Dec 2025 01:03:29 +0900 yk@xxxxxxxxx wrote:
> > + netif_carrier_on(dev_a);
> > + netif_carrier_on(dev_b);
>
> if (netif_running(dev_a) && netif_running(dev_b)) {
> /// your code
> }
>
> right? If one side is down there should be no carrier.

That's right. I have updated the first patch with netif_running()
checks accordingly.

Here is the v3 series including the fix:
https://lore.kernel.org/netdev/cover.1767624906.git.yk@xxxxxxxxx/T/

Thank you,
Yohei Kojima

> --
> pw-bot: cr