Re: [PATCH] ASoC: tegra: Revert fix for uninitialized flat cache warning in tegra210_ahub

[Jon Hunter]

Hi Mark,

On 17/12/2025 13:40, Jon Hunter wrote:
> On 17/12/2025 13:25, Sheetal . wrote:
> > From: sheetal <sheetal@xxxxxxxxxx>
> >
> > Commit 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache warning
> > in tegra210_ahub") attempted to fix the uninitialized flat cache warning
> > that is observed for the Tegra210 AHUB driver. However, the change broke
> > various audio tests because an -EBUSY error is returned when accessing
> > registers from cache before they are read from hardware. Revert this
> > change for now, until a proper fix is available.
> >
> > Fixes: 4d4021b0bbd1 ("ASoC: tegra: Fix uninitialized flat cache 
> > warning in tegra210_ahub")
> > Signed-off-by: sheetal <sheetal@xxxxxxxxxx>
> > ---
> >   sound/soc/tegra/tegra210_ahub.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/tegra/tegra210_ahub.c b/sound/soc/tegra/ 
> > tegra210_ahub.c
> > index 261d9067d27b..e795907a3963 100644
> > --- a/sound/soc/tegra/tegra210_ahub.c
> > +++ b/sound/soc/tegra/tegra210_ahub.c
> > @@ -2077,7 +2077,7 @@ static const struct regmap_config 
> > tegra210_ahub_regmap_config = {
> >       .val_bits        = 32,
> >       .reg_stride        = 4,
> >       .max_register        = TEGRA210_MAX_REGISTER_ADDR,
> > -    .cache_type        = REGCACHE_FLAT_S,
> > +    .cache_type        = REGCACHE_FLAT,
> >   };
> >   static const struct regmap_config tegra186_ahub_regmap_config = {
> > @@ -2085,7 +2085,7 @@ static const struct regmap_config 
> > tegra186_ahub_regmap_config = {
> >       .val_bits        = 32,
> >       .reg_stride        = 4,
> >       .max_register        = TEGRA186_MAX_REGISTER_ADDR,
> > -    .cache_type        = REGCACHE_FLAT_S,
> > +    .cache_type        = REGCACHE_FLAT,
> >   };
> >   static const struct regmap_config tegra264_ahub_regmap_config = {
> > @@ -2094,7 +2094,7 @@ static const struct regmap_config 
> > tegra264_ahub_regmap_config = {
> >       .reg_stride        = 4,
> >       .writeable_reg        = tegra264_ahub_wr_reg,
> >       .max_register        = TEGRA264_MAX_REGISTER_ADDR,
> > -    .cache_type        = REGCACHE_FLAT_S,
> > +    .cache_type        = REGCACHE_FLAT,
> >   };
> >   static const struct tegra_ahub_soc_data soc_data_tegra210 = {
>
>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Now we are into the new year, I just wanted to send a reminder for this 
fix. We need to get this revert into v6.19.

Thanks!
Jon

--
nvpublic