Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator
From: Ian Rogers
Date: Mon Jan 05 2026 - 12:14:19 EST
On Mon, Jan 5, 2026 at 8:46 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2026-01-05 at 07:39 -0800, Ian Rogers wrote:
> > I was the author of it. The patch passed checkpatch.pl but then
> > created a commit with missing tags - ie it was broken. This patch is
> > fixing this issue so that checkpatch.pl will warn about the missing
> > tags prior to the patch being sent to LKML, which is kind of
> > checkpatch.pl's purpose. This is all detailed in the commit message.
>
> Whatever was the tool that applied the patch should be fixed instead.
The tool was git. As I mentioned, we can patch git but old versions
will still have the '^---' rather than '^---$' behavior and so these
checkpatch.pl tests remain useful.
Thanks,
Ian