Re: [PATCH v19 01/10] power: reset: reboot-mode: Remove devres based allocations

From: Shivendra Pratap

Date: Mon Jan 05 2026 - 13:20:25 EST




On 1/2/2026 3:35 PM, Bartosz Golaszewski wrote:
> On Sun, Dec 28, 2025 at 6:20 PM Shivendra Pratap
> <shivendra.pratap@xxxxxxxxxxxxxxxx> wrote:

[snip]

>
>> + pr_err("reboot mode %s without magic number\n", prop->name);
>
> If this is an error, shouldn't we bail out?
>
>> + continue;

This is not an error as per original design of reboot-mode framework.
The code as of now says, if the reboot-mode node has an entry without
proper magic value, ignore it, and, process the next.

thanks,
Shivendra