Re: [PATCH] x86/cpu: drop unused Kconfig symbol X86_P6_NOP

[Dave Hansen]

On 12/28/25 15:27, Randy Dunlap wrote:
> -# Bug fix for binutils: this option is required in order to keep
> -# binutils from generating NOPL instructions against our will.
> -ifneq ($(CONFIG_X86_P6_NOP),y)
> -cflags-y			+= $(call cc-option,-Wa$(comma)-mtune=generic32,)
> -endif

Isn't this adding the cflags when CONFIG_X86_P6_NOP is _not_ =y? Isn't
this the case now that X86_P6_NOP has been zapped from the tree? Doesn't
that make the straightforward "fix" to just remove the reference to
CONFIG_X86_P6_NOP, but leave the cflags-y like this?

-ifneq ($(CONFIG_X86_P6_NOP),y)
 cflags-y	+= $(call cc-option,-Wa$(comma)-mtune=generic32,)
-endif

It's either that or I'm reading the Makefile logic backwards (wouldn't
be the first time :).