Re: [PATCH] of: unittest: fix possible null-pointer dereferences in of_unittest_property_copy()

From: Rob Herring (Arm)
Date: Mon Jan 05 2026 - 17:12:36 EST



On Mon, 05 Jan 2026 15:14:38 +0800, Tuo Li wrote:
> This function first duplicates p1 and p2 into new, and then checks whether
> the duplication succeeds. However, if the duplication fails (e.g.,
> kzalloc() returns NULL in __of_prop_dup()), new will be NULL but is still
> dereferenced in __of_prop_free(). To ensure that the unit test continues to
> run even when duplication fails, add a NULL check before calling
> __of_prop_free().
>
> Fixes: 1c5e3d9bf33b ("of: Add a helper to free property struct")
> Signed-off-by: Tuo Li <islituo@xxxxxxxxx>
> ---
> drivers/of/unittest.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>

Applied, thanks!