Re: [PATCH net-next 01/13] octeontx2-af: npc: cn20k: Index management
From: Ratheesh Kannoth
Date: Mon Jan 05 2026 - 22:30:10 EST
On 2026-01-05 at 20:45:12, Andrew Lunn (andrew@xxxxxxx) wrote:
> > +static void npc_subbank_srch_order_dbgfs_usage(void)
> > +{
> > + pr_err("Usage: echo \"[0]=[8],[1]=7,[2]=30,...[31]=0\" > <debugfs>/subbank_srch_order\n");
>
> Isn't checkpatch giving you warnings about pr_err(). It wants you to
> use something like netdev_err()? This is a network driver, so you
> should have a netdev structure.
>
> Andrew
There was no warning reported by checkpatch. NPC is a global TCAM resource.
This debugfs interface sets the order in which the subbanks (there are 32
subbanks in the NPC) are searched for a free slot. Would you prefer that I
create a dummy netdevice and pass it to this function?