Re: [PATCH v2] uvcvideo: simplify spin_lock using guards
From: Laurent Pinchart
Date: Mon Jan 05 2026 - 22:52:59 EST
On Mon, Jan 05, 2026 at 05:35:12PM +0800, Chen Changcheng wrote:
> > This is an undesired syntax explicitly documented as one to avoid. You
> > need here proper assignment, not NULL. Please don't use cleanup.h if you
> > do not intend to follow it because it does not make the code simpler.
>
> Thank you for your correction and feedback. I made the change initially
> because I saw similar patterns using "__free(...) = NULL" in patches from
> other driver modules, which led me to overlook the core paradigm of
> cleanup.h that requires a "declaration with a meaningful initializer."
Do you plan to send a v3 ?
--
Regards,
Laurent Pinchart