Re: [PATCH] arm64: dts: mediatek: mt8183: Add missing endpoint IDs to display graph

[Chen-Yu Tsai]

On Sun, Dec 7, 2025 at 1:54 AM Otto Pflüger <otto.pflueger@xxxxxxxxx> wrote:
>
> The endpoint IDs in the display graph are expected to match the
> associated display path number, i.e. all endpoints connected to
> mmsys_ep_main must have reg = <0> and all endpoints connected to
> mmsys_ep_ext must have reg = <1>.
>
> Add the missing ID to all endpoints in the display graph, based on
> mt8365.dtsi as an existing example that does this correctly.
>
> Fixes: e72d63fa0563 ("arm64: dts: mediatek: mt8183: Migrate to display controller OF graph")
> Reported-by: Evans Jahja <evansjahja13@xxxxxxxxx>
> Closes: https://lore.kernel.org/linux-mediatek/CAAq5pW9o3itC0G16LnJO7KMAQ_XoqXUpB=cuJ_7e3-H11zKd5Q@xxxxxxxxxxxxxx/
> Signed-off-by: Otto Pflüger <otto.pflueger@xxxxxxxxx>

Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

Restores the display on my MT8183 Juniper device to normal.

> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 122 +++++++++++++++++++++++++------
>  1 file changed, 98 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 4e20a8f2eb25803057955401a7737c7f029a1424..0c73043c67fd01147179e8f9b065684f67749ec2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1754,15 +1754,21 @@ ports {
>                                 #size-cells = <0>;
>
>                                 port@0 {
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
>                                         reg = <0>;

"reg" (and "compatible") properties should come before all other ones,
as documented in the device tree coding style. This applies to all the
additions in this patch.


ChenYu