Re: [PATCH 1/2] drm: xlnx: zynqmp_kms: Init fbdev with 16 bit color

[Thomas Zimmermann]

Hi

Am 05.12.25 um 13:37 schrieb Mikko Rapeli:
> From: Anatoliy Klymenko <anatoliy.klymenko@xxxxxxx>
>
> Use RG16 buffer format for fbdev emulation. Fbdev backend is being used
> by Mali 400 userspace driver which expects 16 bit RGB pixel color format.
> This change should not affect console or other fbdev applications as we
> still have plenty of colors left.
>
> Cc: Bill Mills <bill.mills@xxxxxxxxxx>
> Cc: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@xxxxxxx>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

although with patch 2 applied, you can simply call 
'drm_client_setup(drm, NULL)' and it should do the right thing.

Best regards
Thomas

> ---
>   drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index 2bee0a2275ede..ccc35cacd10cb 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -525,7 +525,7 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
>   		goto err_poll_fini;
>   
>   	/* Initialize fbdev generic emulation. */
> -	drm_client_setup_with_fourcc(drm, DRM_FORMAT_RGB888);
> +	drm_client_setup_with_fourcc(drm, DRM_FORMAT_RGB565);
>   
>   	return 0;
>   

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)