Re: [PATCH v1] pwm: dwc: Use size macro

[Raag Jadav]

On Mon, Jan 05, 2026 at 08:07:07PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 05, 2026 at 05:51:34PM +0100, Raag Jadav wrote:
> > On Mon, Jan 05, 2026 at 06:41:48PM +0200, Andy Shevchenko wrote:
> > > On Mon, Jan 05, 2026 at 02:47:37PM +0530, Raag Jadav wrote:
> > > > Use SZ_4K from size.h instead of hardcoding constant.
> > > 
> > > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > 
> > Thank you.
> > 
> > > OTOH, not sure if it's just an unneeded churn. What was the motivation to
> > > create this patch?
> 
> > Your hard work[1] continues to motivate me :)
> 
> Ha-ha, but that one has a principal difference, i.e. there was _a custom macro_
> *already*, which was replaced with a generic one. From the code perspective
> it's not a churn as it kills the unneeded custom macro. Here the situation is
> different, i.e. the explicit number 0x1000 is changed to SZ_4K. Just a line to
> change, the added header inclusion and no other changes, so as a standalone one
> it sounds to me like a churn.

Fair, but converting to standard macro is noteworthy IMHO.
I'll leave the final call to you all.

Raag

> > [1] https://lore.kernel.org/r/20250825163545.39303-3-andriy.shevchenko@xxxxxxxxxxxxxxx