Re: [PATCH v2 4/4] arm64: dts: qcom: talos-evk-camera: Add DT overlay

[Vladimir Zapolskiy]

On 1/7/26 07:55, Wenmeng Liu wrote:
> On 1/7/2026 1:16 PM, Vladimir Zapolskiy wrote:
> > On 1/7/26 05:05, Wenmeng Liu wrote:
> > > On 1/7/2026 2:23 AM, Dmitry Baryshkov wrote:
> > > > On Tue, Jan 06, 2026 at 05:39:56PM +0800, Wenmeng Liu wrote:
> > > > > Enable IMX577 via CCI on Taloss EVK Core Kit.
> > > > >
> > > > > The Talos EVK board does not include a camera sensor
> > > > > by default, this overlay reflects the possibility of
> > > > > attaching an optional camera sensor.
> > > > > For this reason, the camera sensor configuration is
> > > > > placed in talos-evk-camera.dtso, rather than
> > > > > modifying the base talos-evk.dts.
> > > > >
> > > > > Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
> > > > > ---
> > > > >     arch/arm64/boot/dts/qcom/Makefile              |  2 +
> > > > >     arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 63 +++++++++++++
> > > > > +++++++++++++
> > > >
> > > > Is it possible to attach other sensors? If so, overlay name should
> > > > depicit which sensors are attached (compare this to the RBn boards where
> > > > specifying "vision kit" defines all sensors attached to the device).
> > >
> > > Okay, we previously had a discussion on this. I will rename the file to
> > > talos-evk-camera-imx577.dtso.
> >
> > Other camera or display .dtso names commonly repeat the name given by
> > the vendor, and the bare minimum is to name it the commit message or in
> > the code. Is it Arducam 12.3MP IMX577 Mini Camera Module or something else?
>
> I believe that modifications for the sensor do not need to include
> Arducam descriptions, because this DTS is intended to support this
> sensor module. Even if it is replaced with another vendor`s IMX577
> sensor, it should still work.

Most probably yes, if the connector type and its pads are one-to-one equal,
but before such another camera sensor module appears, it makes sense to
mention at least in the commit message the exact type of the sensor module,
which has been tested and supported by your change.

Hopefully, it should not be too complicated to add a line into the commit
message, that the change supports Arducam 12.3MP IMX577 Mini Camera Module.

--
Best wishes,
Vladimir