Re: [PATCH] powercap: dtpm: Fix format string issues in log messages
From: Rafael J. Wysocki
Date: Wed Jan 07 2026 - 17:29:39 EST
On Fri, Dec 19, 2025 at 7:45 PM Sumeet Pawnikar <sumeet4linux@xxxxxxxxx> wrote:
>
> Fix few format string issues in dtpm.c file,
> - Extra trailing comma and space in the debug message "Registered
> dtpm node '%s' / %llu-%llu uW, \n". This unnecessary trailing ", "
> before the newline character, resulting an illusion of some more
> message available for this under debug output.
>
> - Incorrect log level for subsystem initialization failure message.
> There is an error condition, not informational, and should be logged
> at error level for consistency with other failure mssages. Changed
> pr_info() to pr_err() for this subsystem initialization failure
> message.
Please leave it as is.
Error-level messages in the kernel log are only useful if the
user/admin of the system can do something about them, but this doesn't
seem to be the case here.