Re: [PATCH v3 1/2] HID: intel-ish-hid: loader: Add PRODUCT_FAMILY-based firmware matching

[Jiri Kosina]

On Mon, 22 Dec 2025, Vishnu Sankar wrote:

> Add support for firmware filenames that include the CRC32 checksum of the
> DMI product_family field. Several OEMs ship ISH firmware variants shared
> across a product family while product_name or product_sku may differ. This
> intermediate matching granularity reduces duplication and improves firmware
> selection for vendor-customized platforms.
> 
> The newly supported filename forms are checked before existing patterns:
> 
>   ish_${gen}_${vendor}_${family}_${name}_${sku}.bin
>   ish_${gen}_${vendor}_${family}_${sku}.bin
>   ish_${gen}_${vendor}_${family}_${name}.bin
>   ish_${gen}_${vendor}_${family}.bin
> 
> The legacy product_name/product_sku rules remain unchanged and continue
> to provide fallback matching.
> 
> ISH_FW_FILENAME_LEN_MAX is changed to 72 to accommodate the product_family.
> 
> Tested with X9 series and X1 series.
> 
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Tested-by: Richie Roy Jayme <rjayme.jp@xxxxxxxxx>
> Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx>

Applied both to hid.git#for-6.20/intel-ish, thanks.

-- 
Jiri Kosina
SUSE Labs