Re: [PATCH v2] scsi: ufs: exynos: call phy_notify_state() from hibern8 callbacks

[Bart Van Assche]

On 1/7/26 5:51 AM, Peter Griffin wrote:
> +	union phy_notify phystate = {
> +		.ufs_state = PHY_UFS_HIBERN8_EXIT
> +	};

Should this be declared 'static const'?

> +		phy_notify_state(ufs->phy, phystate);

Can you please ask the maintainer of include/linux/phy/phy.h why
phy_notify is a union since it only has a single member? From that
header file:

union phy_notify {
	enum phy_ufs_state ufs_state;
};

> +	union phy_notify phystate = {
> +		.ufs_state = PHY_UFS_HIBERN8_ENTER
> +	};

Same question here: should this be declared 'static const'?

Thanks,

Bart.