Re: [PATCH v10 4/5] arm64: dts: qcom: talos: Fix inconsistent USB PHY node naming
From: tessolveupstream
Date: Wed Jan 07 2026 - 23:51:36 EST
On 07-01-2026 13:53, yuanjiey wrote:
> On Tue, Dec 30, 2025 at 06:32:26PM +0530, Sudarshan Shetty wrote:
>> The USB PHY nodes has inconsistent labels as 'usb_1_hspy'
>> and 'usb_hsphy_2'. This patch renames them to follow
>> a consistent naming scheme.
>>
>> No functional changes, only label renaming.
>>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@xxxxxxxxx>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
>> index 95d26e313622..c7dc507a50b5 100644
>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
>> @@ -4304,7 +4304,7 @@ osm_l3: interconnect@18321000 {
>> #interconnect-cells = <1>;
>> };
>>
>> - usb_1_hsphy: phy@88e2000 {
>> + usb_hsphy_1: phy@88e2000 {
>
> Here just modify talos.dtsi, not modify qcs615-ride.dts
>
> we will meet compile error.
>
> Error: arch/arm64/boot/dts/qcom/qcs615-ride.dts:635.1-13 Label or path usb_1_hsphy not found.
>
Okay, got it. I will make the necessary changes in qcs615-ride.dts
in the next patch series.
> Thanks,
> Yuanjie
>
> compatible = "qcom,qcs615-qusb2-phy";
>> reg = <0x0 0x88e2000 0x0 0x180>;
>>
>> @@ -4412,7 +4412,7 @@ usb_1_dwc3: usb@a600000 {
>> iommus = <&apps_smmu 0x140 0x0>;
>> interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
>>
>> - phys = <&usb_1_hsphy>, <&usb_qmpphy>;
>> + phys = <&usb_hsphy_1>, <&usb_qmpphy>;
>> phy-names = "usb2-phy", "usb3-phy";
>>
>> snps,dis-u1-entry-quirk;
>> --
>> 2.34.1