Re: [PATCH V3 2/4] media: i2c: ds90ub960: Use enums for chip type and chip family
From: Jai Luthra
Date: Tue Jan 06 2026 - 06:26:46 EST
Hi Abhilash,
Thank you for the patch.
Quoting Yemike Abhilash Chandra (2025-12-19 17:59:53)
> Replace chip-specific boolean flags with chip_type and chip_family enums.
> This simplifies the process of adding support for newer devices and also
> improves code readability.
>
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@xxxxxx>
> ---
> Changelog:
> Changes in v3:
> - Change conditional checks to check for applicable chips over negated checks. (Tomi)
> - Keep the model name in the ub960_hw_data structure and remove the switch-case from the probe function. (Tomi)
>
> drivers/media/i2c/ds90ub960.c | 38 +++++++++++++++++++++++------------
> 1 file changed, 25 insertions(+), 13 deletions(-)
>
Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
[...]