Re: [PATCH] gpu: nova-core: use CStr::from_bytes_until_nul() and remove util.rs
From: Danilo Krummrich
Date: Tue Jan 06 2026 - 07:02:57 EST
On Sat Jan 3, 2026 at 2:34 AM CET, John Hubbard wrote:
> @@ -209,7 +208,9 @@ impl GetGspStaticInfoReply {
> /// Returns the name of the GPU as a string, or `None` if the string given by the GSP was
> /// invalid.
> pub(crate) fn gpu_name(&self) -> Option<&str> {
> - util::str_from_null_terminated(&self.gpu_name)
> + CStr::from_bytes_until_nul(&self.gpu_name)
> + .ok()
> + .and_then(|cstr| cstr.to_str().ok())
> }
> }
Did you see my reply in [1]? The question is orthogonal to this change, but
perhaps it can be addressed with a subsequent patch?
[1] https://lore.kernel.org/lkml/DFEVITW4O9DW.P4ITE1PWIDY6@xxxxxxxxxx/