Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[Marco Felsch]

Hi Frank,

thanks for fixing this.

On 26-01-06, Frank Li wrote:
> Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> description to set SPI mode") required both 'default' and 'reset' pinctrl
> states for all compatible devices. However, this requirement should be only
> applicable to KSZ8463.
> 
> Make the 'reset' pinctrl state optional for all other Microchip DSA
> devices while keeping it mandatory for KSZ8463.
> 
> Fix below CHECK_DTBS warnings:
>   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
> 

Fixes tag?

> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index a8c8009414ae0..8d4a3a9a33fcc 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -40,6 +40,7 @@ properties:
>        - const: reset
>          description:
>            Used during reset for strap configuration.
> +    minItems: 1

Does this mean that all others can now either specify 'reset' or
'default'? If yes, this seems wrong.

Regards,
  Marco

>  
>    reset-gpios:
>      description:
> @@ -153,6 +154,8 @@ allOf:
>              const: microchip,ksz8463
>      then:
>        properties:
> +        pinctrl-names:
> +          minItems: 2
>          straps-rxd-gpios:
>            description:
>              RXD0 and RXD1 pins, used to select SPI as bus interface.
> -- 
> 2.34.1
> 
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |