Re: [PATCH v4 1/4] i3c: renesas: Switch to clk_bulk API and store clocks in private data
From: Alexandre Belloni
Date: Tue Jan 06 2026 - 10:54:29 EST
On 06/01/2026 15:41:10+0000, Biju Das wrote:
> > This is just more flexiable for clk schema. If your schema is simple enough check num_clks >
> > RENESAS_I3C_TCLK_IDX should be enough.
>
> For avoiding crash that check is sufficient, but as you said wrong dtb like crash
> can also lead to non-functional i3c device
>
> Eg:
>
> From bindings, we expect the below entries in DTS for RZ/G3S
>
> "pclk", "tclk" for RZ/G3S
>
> But user mistakenly just added "pclk", that will lead to kernel crash
>
> Or
>
> Swap the clocks
>
> "tclk", "pclk" this will lead to non-functional i3c device
>
> On both cases, user ignored DT binding check warnings.
>
> As you said crash is fatal, maybe stick with just num_clks > RENESAS_I3C_TCLK_IDX
Yes, this is enough
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com