Re: [PATCH] tools/testing/selftests: fix gup_longterm for unknown fs

From: Andrew Morton

Date: Tue Jan 06 2026 - 12:28:37 EST


On Tue, 6 Jan 2026 15:45:47 +0000 Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote:

> Commit 66bce7afbaca ("selftests/mm: fix test result reporting in
> gup_longterm") introduced a small bug causing unknown filesystems to always
> result in a test failure.
>
> This is because do_test() was updated to use a common reporting path, but
> this case appears to have been missed.
>
> This is problematic for e.g. virtme-ng which uses an overlayfs file system,
> causing gup_longterm to appear to fail each time due to a test count
> mismatch:
>
> # Planned tests != run tests (50 != 46)
> # Totals: pass:24 fail:0 xfail:0 xpass:0 skip:22 error:0
>
> The fix is to simply change the return into a break.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> Fixes: 66bce7afbaca ("selftests/mm: fix test result reporting in gup_longterm")

-stable users might want this?