Re: [PATCH 2/7] media: dt-bindings: Add CAMSS device for SM8750

[Vijay Kumar Tumati]

On 12/3/2025 5:31 PM, Vladimir Zapolskiy wrote:
> On 11/27/25 10:10, Krzysztof Kozlowski wrote:
> > On Wed, Nov 26, 2025 at 01:38:35AM -0800, Hangxiang Ma wrote:
> > > Add the compatible string "qcom,sm8750-camss" to support the Camera
> >
> > s/to support the/for the/
> >
> > Bindings do not support hardware.
> >
> > > Subsystem (CAMSS) on the Qualcomm SM8750 platform.
> > >
> > > The SM8750 platform provides:
> > > - 3 x VFE, 5 RDI per VFE
> > > - 2 x VFE Lite, 4 RDI per VFE Lite
> > > - 3 x CSID
> > > - 2 x CSID Lite
> > > - 6 x CSIPHY
> > > - 2 x ICP
> > > - 1 x IPE
> > > - 2 x JPEG DMA & Downscaler
> > > - 2 x JPEG Encoder
> > > - 1 x OFE
> > > - 5 x RT CDM
> > > - 3 x TPG
> > >
> > > Signed-off-by: Hangxiang Ma <hangxiang.ma@xxxxxxxxxxxxxxxx>
> > > ---
> > >   .../bindings/media/qcom,sm8750-camss.yaml          | 664 
> > > +++++++++++++++++++++
> > >   1 file changed, 664 insertions(+)
> > >
> > > diff --git 
> > > a/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml 
> > > b/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml
>
> <snip>
>
> > > +
> > > +  vdd-csiphy0-0p88-supply:
> >
> > 88->8, so: vdd-csiphy0-0p8-supply:
>
> I would make a minor correction here, it'd be rather 0p9.
Sure, thanks.
> > Same in other places. This is how it is called for every binding.
> >
> > > +    description:
> > > +      Phandle to a 0.88V regulator supply to CSIPHY0 core block.
> > > +
> > > +  vdd-csiphy0-1p2-supply:
> > > +    description:
> > > +      Phandle to a 1.2V regulator supply to CSIPHY0 pll block.
> > > +
> > > +  vdd-csiphy1-0p88-supply:
> > > +    description:
> > > +      Phandle to a 0.88V regulator supply to CSIPHY1 core block.