Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss
From: Vijay Kumar Tumati
Date: Tue Jan 06 2026 - 14:43:11 EST
On 1/6/2026 11:20 AM, Krzysztof Kozlowski wrote:
On 06/01/2026 20:18, Krzysztof Kozlowski wrote:Agreed. Apologies for the delay. It was partly caused by the dependency that these patches have on Kaanapali patches and partly by vacations during Christmas. We will explore and address your concerns reg CCI nodes and push the next revision ASAP. Thanks for your understanding, Krzysztof.
On 06/01/2026 19:40, Vijay Kumar Tumati wrote:Look here^
On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote:
On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote:
Why would pinctrl nodes matter anyhow? Please read how DTS syntax works.Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are+ };Looks completely mis-ordered/sorted. What are the nodes above and below?
+
+ cci0: cci@ac7b000 {
the pinctrl nodes. Each CCI has two masters using two GPIOs each, one
for clk and one for data. The ones below are the actual CCI HW nodesI wrote what is wrong. Is this maintaining proper sorting? Did you read
that make use of the pinctrls. I believe this is inline with previous
generations. Have I missed something? Thanks.
DTS coding style?
Heh, you received my review 1 day after your posting.
You replied to my review 5-6 weeks after, yet you still expect me to
understand the context and provide clarifications.
There is simpler way: NAK.
You will not get your patches merged with such latency and such replies
not even trying to address the problem or learn about it.
Best regards,
Krzysztof