Re: [PATCH] lsm: make keys for static branch static

From: Paul Moore

Date: Tue Jan 06 2026 - 20:57:55 EST


On Jan 6, 2026 Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote:
>
> The key use for static-branches are not refrenced by name outside
> of the security/security.c file, so make them static. This stops
> the sparse warnings about "Should it be static?" such as:
>
> security/security.c: note: in included file:
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_0' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_1' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_2' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:30:1: warning: symbol 'security_hook_active_binder_transaction_0' was not declared. Should it be static?
> ...
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> security/security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Merged into lsm/dev, thanks.

--
paul-moore.com