Re: [PATCH v2] x86/cpu: drop unused Kconfig symbol X86_P6_NOP
From: H. Peter Anvin
Date: Tue Jan 06 2026 - 22:50:58 EST
On 2026-01-05 17:47, Randy Dunlap wrote:
> This symbol was removed in early 2025 but 2 dangling references to it
> were missed. Delete them now.
>
> It's safe to drop the -mtune=generic32 option since gcc 4.3 doesn't
> cause the problem (see 28f7e66fc1da ("x86: prevent binutils from being
> "smart" and generating NOPLs for us")). Also, Arnd confirmed this with
> gcc-8 and gcc-15.
>
> Fixes: f388f60ca904 ("x86/cpu: Drop configuration options for early 64-bit CPUs")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reviewed-by: Nikolay Borisov <nik.borisov@xxxxxxxx>
> ---
> v2: add Reviewed-by Nikolay; add -mtune explanation (Dave, Arnd: thanks);
> add Cc to HPA;
>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
>
Acked-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>
-hpa