Re: [PATCH 0/2] Add Apple Silicon SMC power driver

[Neal Gompa]

On Mon, Jan 5, 2026 at 7:56 AM Michael Reeves via B4 Relay
<devnull+michael.reeves077.gmail.com@xxxxxxxxxx> wrote:
>
> This series adds a power supply driver for the Apple SMC found on
> Apple Silicon devices. This allows the kernel to report AC status,
> battery charging status, and power metrics, and modify the charging
> behaviour.
>
> The first patch adds the driver itself, and the second patch wires it
> up to the MFD core.
>
> The driver is based on an original out-of-tree implementation by
> Hector Martin. It has been refactored for upstream inclusion,
> including support for newer SMC firmwares, devices without batteries,
> dynamic property detection and improved state management.
>
> Tested on: Apple M3 (MacBook Air, J613)
>
> Signed-off-by: Michael Reeves <michael.reeves077@xxxxxxxxx>
> ---
> Michael Reeves (2):
>       power: supply: Add macsmc-power driver for Apple Silicon
>       mfd: macsmc: Wire up Apple SMC power driver
>
>  MAINTAINERS                         |   1 +
>  drivers/mfd/macsmc.c                |   1 +
>  drivers/power/supply/Kconfig        |  11 +
>  drivers/power/supply/Makefile       |   1 +
>  drivers/power/supply/macsmc-power.c | 872 ++++++++++++++++++++++++++++++++++++
>  5 files changed, 886 insertions(+)
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20260105-b4-macsmc-power-d017cc7f53ac
>

LGTM, thanks for this work!

Reviewed-by: Neal Gompa <neal@xxxxxxxxx>


-- 
真実はいつも一つ！/ Always, there's only one truth!