Re: [PATCH] Coding Style: Format arch/arm/boot/dts/xilinx

[Michal Simek]

Hi,

On 1/6/26 21:28, kylebonnici wrote:
> Hi,

first of all please don't do top posting.

> Thanks for the feedback.
>
> with regard to subject I am not sure in what subsystem file formatting would go (especially if we run it on even more files and more systems are modified) Your guidance would be appreciated.

arm: xilinx:

or for 64 bit version

arm64: xilinx:

> With regard to improving the line wrapping, can you share some examples so that I can start looking on improving this?


run it over zynqmp.dtsi file
And focus on pcie node

 @@ -958,8 +979,10 @@ pcie: pcie@fd0e0000 {
                               <0x0 0xfd480000 0x0 0x1000>,
                               <0x80 0x00000000 0x0 0x10000000>;
                         reg-names = "breg", "pcireg", "cfg";
 -                       ranges = <0x02000000 0x00000000 0xe0000000 0x00000000 
0xe0000000 0x00000000 0x10000000>,/* non-prefetchable memory */
 -                                <0x43000000 0x00000006 0x00000000 0x00000006 
0x00000000 0x00000002 0x00000000>;/* prefetchable memory */
 +                       ranges = <0x02000000 0x00000000 0xe0000000 0x00000000 
0xe0000000 0x00000000
 +                                 0x10000000>,/* non-prefetchable memory */
 +                                <0x43000000 0x00000006 0x00000000 0x00000006 
0x00000000 0x00000002
 +                                 0x00000000>;/* prefetchable memory */
                         bus-range = <0x00 0xff>;

1. sometimes commens are using space,tab or nothing. Same style would be useful.
2. last cell on next line looks weird to me. I think you can decode 
address-cells/size-cells for ranges and do indentation base on it.

> To run on more files I will wait for feedback from Rob, Krzysztof and Conor.

yep.

Thanks,
Michal