Re: [PATCH] perf build: Raise minimum shellcheck version to 0.7.2

[Nicolas Schier]

On Tue, Jan 06, 2026 at 11:36:59PM -0800, Namhyung Kim wrote:
> On Tue, Jan 06, 2026 at 02:19:28PM +0100, Nicolas Schier wrote:
> > Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> > systems with shellcheck versions below 0.7.2 will automatically skip the
> > shell script checking, even if NO_SHELLCHECK is unset.
> > 
> > Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> > paths"), shellcheck versions before 0.7.2 break the perf build with
> > several SC1090 [2] warnings due to its too strict dynamic source
> > handling [1].
> 
> It'd be nice if you could copy the error message here.

Sure.  I'll send v2 with one of the messages included here.

> > 
> > Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
> > Link: https://github.com/koalaman/shellcheck/issues/1998 # [1]
> > Link: https://www.shellcheck.net/wiki/SC1090
> > Signed-off-by: Nicolas Schier <n.schier@xxxxxx>
> 
> Other than that,
> 
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks.

Kind regards,
Nicolas

Attachment: signature.asc
Description: PGP signature