Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
From: Krzysztof Kozlowski
Date: Wed Jan 07 2026 - 03:20:18 EST
On 22/12/2025 14:06, Jishnu Prakash wrote:
> Hi Krzysztof,
>
> On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote:
>> On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
>>> Add support for PMH0101 PWM modules which are compatible with the PM8350c
>>> PWM modules.
>>>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
>>> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
>>> ---
>>> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> So how many nvmem entries it has? You need to define it in schema.
>>
>
> PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that
> PM8550 PWM was earlier added under the "if:then" condition for the number
> of nvmem entries and you made this change which removed that line:
Right, code is fine.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof