Re: [PATCH v4 3/6] PCI: dwc: Rework the error print of dw_pcie_wait_for_link()

[Shawn Lin]

在 2026/01/07 星期三 16:11, Manivannan Sadhasivam via B4 Relay 写道:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
>
> If the link fails to come up even after detecting the device on the bus
> i.e., if the LTSSM is not in Detect.Quiet and Detect.Active states, then
> dw_pcie_wait_for_link() should log it as an error.
>
> So promote dev_info() to dev_err(), reword the error log to make it clear
> and also print the LTSSM state to aid debugging.

LTSSM might still be changing, so not sure how much value it would be
to print it at a singal moment, but anyway

Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> ---
>   drivers/pci/controller/dwc/pcie-designware.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 87f2ebc134d6..c2dfadc53d04 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -776,7 +776,8 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>   			return -ENODEV;
>   		}
>   
> -		dev_info(pci->dev, "Phy link never came up\n");
> +		dev_err(pci->dev, "Link failed to come up. LTSSM: %s\n",
> +			dw_pcie_ltssm_status_string(ltssm));
>   		return -ETIMEDOUT;
>   	}
>