Re: [PATCH v3 04/22] drm/tilcdc: Add support for DRM bus flags and simplify panel config

From: Kory Maincent

Date: Wed Jan 07 2026 - 04:37:13 EST


On Tue, 6 Jan 2026 13:30:40 -0600
Andrew Davis <afd@xxxxxx> wrote:
> > static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> > {
> > struct drm_device *ddev;
> > struct platform_device *pdev = to_platform_device(dev);
> > struct device_node *node = dev->of_node;
> > + const struct of_device_id *of_id;
> > struct tilcdc_drm_private *priv;
> > u32 bpp = 0;
> > int ret;
> > @@ -209,6 +222,10 @@ static int tilcdc_init(const struct drm_driver *ddrv,
> > struct device *dev) if (IS_ERR(ddev))
> > return PTR_ERR(ddev);
> >
> > + of_id = of_match_node(tilcdc_of_match, node);
>
> You should be able to use `device_get_match_data()` here, then you would
> also be able to keep the tilcdc_of_match table down were it was before.

Indeed. Didn't know this helper.
Thanks you!

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com