Re: [PATCH RFC net-next 2/6] net: phy: add support to set default rules

[Jijie Shao]

on 2026/1/2 19:26, Russell King (Oracle) wrote:
> On Wed, Dec 17, 2025 at 08:54:59PM +0800, Jijie Shao wrote:
> > on 2025/12/16 15:09, Andrew Lunn wrote:
> > > On Mon, Dec 15, 2025 at 08:57:01PM +0800, Jijie Shao wrote:
> > > > The node of led need add new property: rules,
> > > > and rules can be set as:
> > > > BIT(TRIGGER_NETDEV_LINK) | BIT(TRIGGER_NETDEV_RX)
> > > Please could you expand this description. It is not clear to my why it
> > > is needed. OF systems have not needed it so far. What is special about
> > > your hardware?
> > I hope to configure the default rules.
> > Currently, the LED does not configure rules during initialization; it uses the default rules in the PHY registers.
> > I would like to change the default rules during initialization.
> One of the issues here is that there are boards out there where the boot
> loader has configured the PHY LED configuration - and doesn't supply it
> via DT (because PHY LED configuration in the kernel is a new thing.)
>
> Adding default rules for LEDs will break these platforms.
>
> Please find a way to provide the LED rules via firmware rather than
> introducing some kind of rule defaulting.


Actually, in my code, `default_rules` is an optional configuration;
you can choose not to set default rules.

Thanks,
Jijie Shao