Re: [PATCH v2 RESEND v2 3/3] media: atomisp: propagate errors from ISP xnr and IRQ enable

From: Dan Carpenter

Date: Wed Jan 07 2026 - 09:33:22 EST


On Wed, Jan 07, 2026 at 07:18:44PM +0530, Karthikey D Kadati wrote:
> Propagate the return value of atomisp_css_capture_enable_xnr() in
>
> atomisp_xnr().
>
> Also check the return value of atomisp_css_irq_enable() and log an
>
> error once using dev_err_once() to avoid flooding dmesg.
>

Leave off the "to avoid flooding dmesg" because otherwise it makes it
sound like we were flooding dmesg before. Just say: "Also print an
error message if atomisp_css_irq_enable() fails".

regards,
dan carpenter